[ https://issues.apache.org/jira/browse/YARN-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271331#comment-17271331 ]
Gergely Pollak commented on YARN-10425: --------------------------------------- [~ahussein]Thank you for the feedback, I've created the followup Jira YARN-10597 . You are right, this shouldn't instantiated by the {{CSMappingPlacementRule}} class, because it will break the cache. The oversight was when I checked it, I thought the legacy code worked this way, and that's why I kept it here. However now I've double checked, and I realized, I must had checked an older branch last time, since it was fixed about a year ago. So thank you for pointing this out. We'll need to update a few tests, but I'll take a look at them. > Replace the legacy placement engine in CS with the new one > ---------------------------------------------------------- > > Key: YARN-10425 > URL: https://issues.apache.org/jira/browse/YARN-10425 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Gergely Pollak > Assignee: Gergely Pollak > Priority: Major > Fix For: 3.4.0 > > Attachments: YARN-10425.001.patch, YARN-10425.002.patch, > YARN-10425.003.patch, YARN-10425.004.patch, YARN-10425.005.patch, > YARN-10425.006.patch, YARN-10425.007.patch > > > Remove the UserGroupMapping and ApplicationName mapping classes, and use the > new CSMappingPlacementRule instead. Also cleanup the orphan classes which are > used by these classes only. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org