[ https://issues.apache.org/jira/browse/YARN-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293128#comment-17293128 ]
Peter Bacsko commented on YARN-10655: ------------------------------------- I can't really comment on the changes because I'm very unfamiliar with the newly introduced class. The test method can be simplified: {noformat} try { createQueue("root.a.a-auto.a2-auto.a3-auto"); Assert.fail("Queue creation should not succeed because the distance " + "from the first static parent is above limit"); } catch (SchedulerDynamicEditException ignored) { } {noformat} Instead of the try-catch block, just use {{@Test(expected = SchedulerDynamicEditException.class)}} and remove the assertion. > Limit queue creation depth relative to its first static parent > -------------------------------------------------------------- > > Key: YARN-10655 > URL: https://issues.apache.org/jira/browse/YARN-10655 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn > Reporter: Andras Gyori > Assignee: Andras Gyori > Priority: Major > Attachments: YARN-10655.001.patch > > > YARN-10506 introduced a limit on the maximum depth of auto queue creation. > This, however, only limits the levels of queue path relative to its first > existing parent queue. It poses an unnecessary limitation on users, while > providing no real safety net over rogue users (especially when YARN-10632 > makes this limit configurable), because it could be incrementally > circumvented by creating a new queue under an existing dynamic parent queue. > By bounding this limit to the first static parent queue in the hierarchy, we > could have a safer alternative. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org