[ 
https://issues.apache.org/jira/browse/YARN-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298861#comment-17298861
 ] 

Peter Bacsko commented on YARN-10571:
-------------------------------------

[~gandras] thanks for the patch.

I just have one question: the class {{CapacitySchedulerAutoQueueHandler}} was 
renamed to {{CapacitySchedulerQueueHandler}}. But the latter is telling me that 
this is class which handles all kinds of queues, not just auto-created queues. 
Wouldn't it make sense to keep the original name? Even the instance is called 
{{autoQueueHandler}}.

Also, there's a Javadoc and a checkstyle problem.

> Refactor dynamic queue handling logic
> -------------------------------------
>
>                 Key: YARN-10571
>                 URL: https://issues.apache.org/jira/browse/YARN-10571
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Minor
>         Attachments: YARN-10571.001.patch
>
>
> As per YARN-10506 we have introduced an other mode for auto queue creation 
> and a new class, which handles it. We should move the old, managed queue 
> related logic to CSAutoQueueHandler as well, and do additional cleanup 
> regarding queue management.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to