[
https://issues.apache.org/jira/browse/YARN-10652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302845#comment-17302845
]
Szilard Nemeth commented on YARN-10652:
---------------------------------------
Hi [~sahuja],
Answering your comment from
[here|https://issues.apache.org/jira/browse/YARN-10652?focusedCommentId=17295634&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17295634].
1. This might be tough to implement but [~pbacsko] and [~shuzirra] know the
internals of the placement engine better than myself.
2. I think it's okay to have it documented, so I'd choose this from your
suggestions. Could you please file a jira for this?
3. This is also a good idea.
Furthermore, can you file a follow-up jira (you can file more if necessary) as
suggested by [Peter's
comment|https://issues.apache.org/jira/browse/YARN-10652?focusedCommentId=17295964&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17295964]
to cover the problematic cases we already discovered during code inspection
and while having our discussion here?
All in all, if you file follow-up jiras to make this use-case more stable and
consistent, I'm fine.
So, I'm giving +1 (binding) for your patch.
[~wilfreds] I get your point with the last comment.
Based on my comment above: As you wanted to commit this in the first place,
please go ahead with committing.
Thanks.
> Capacity Scheduler fails to handle user weights for a user that has a "."
> (dot) in it
> -------------------------------------------------------------------------------------
>
> Key: YARN-10652
> URL: https://issues.apache.org/jira/browse/YARN-10652
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler
> Affects Versions: 3.3.0
> Reporter: Siddharth Ahuja
> Assignee: Siddharth Ahuja
> Priority: Major
> Attachments: Correct user weight of 0.76 picked up for the user with
> a dot after the patch.png, Incorrect default user weight of 1.0 being picked
> for the user with a dot before the patch.png, YARN-10652.001.patch
>
>
> AD usernames can have a "." (dot) in them i.e. they can be of the format ->
> {{firstname.lastname}}. However, if you specify a username with this format
> against the Capacity Scheduler setting ->
> {{yarn.scheduler.capacity.root.default.user-settings.firstname.lastname.weight}},
> it fails to be applied and is instead assigned the default of 1.0f weight.
> This renders the user weight feature (being used as a means of setting user
> priorities for a queue) unusable for such users.
> This limitation comes from [1]. From [1], only word characters (A word
> character: [a-zA-Z_0-9]) (see [2]) are permissible at the moment which is no
> good for AD names that contain a "." (dot).
> Similar discussion has been had in a few HADOOP jiras e.g. HADOOP-7050 and
> HADOOP-15395 and the outcome was to use non-whitespace characters i.e.
> instead of {{\w+}}, use {{\S+}}.
> We could go down similar path and unblock this feature for the AD usernames
> with a "." (dot) in them.
> [1]
> https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java#L1953
> [2]
> https://docs.oracle.com/javase/tutorial/essential/regex/pre_char_classes.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
