[jira] [Commented] (YARN-10704) The CS effective capacity for absolute mode in UI should support GPU and other custom resources.

[Peter Bacsko (Jira)]

    [ 
https://issues.apache.org/jira/browse/YARN-10704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17306154#comment-17306154
 ] 

Peter Bacsko commented on YARN-10704:
-------------------------------------

Thanks [~zhuqi] I have some minor comments:

1.
{noformat}
            sb.append("<memory:").append(resourceInfo.
                getMemorySize()).append(", vCores:")
                .append(resourceInfo.getvCores());
{noformat}

could you reformat this to

{noformat}
            sb.append("<memory:")
                  .append(resourceInfo.getMemorySize())
                  .append(", vCores:")
                  .append(resourceInfo.getvCores());
{noformat}

for better readability.

2. Please restore these imports:

{noformat}
import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler;
import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacitySchedulerConfiguration;
import org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CSQueue;
import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.ParentQueue;
import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.PlanQueue;
import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.QueueCapacities;
{noformat}

Now its {{import 
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.*;}}

I think we can ignore the checkstyle because everything is "protected" in this 
class anyway.

> The CS effective capacity for absolute mode in UI should support GPU and 
> other custom resources.
> ------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10704
>                 URL: https://issues.apache.org/jira/browse/YARN-10704
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Qi Zhu
>            Assignee: Qi Zhu
>            Priority: Major
>         Attachments: YARN-10704.001.patch, YARN-10704.002.patch, 
> image-2021-03-19-12-05-28-412.png, image-2021-03-19-12-08-35-273.png
>
>
> Actually there are no information about the effective capacity about GPU in 
> UI for absolute resource mode.
> !image-2021-03-19-12-05-28-412.png|width=873,height=136!
> But we have this information in QueueMetrics:
> !image-2021-03-19-12-08-35-273.png|width=613,height=268!
>  
> It's very important for our GPU users to use in absolute mode, there still 
> have nothing to know GPU absolute information in CS Queue UI. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org