[
https://issues.apache.org/jira/browse/YARN-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312516#comment-17312516
]
Peter Bacsko commented on YARN-9618:
------------------------------------
Small things:
1.
{noformat}
//Is trigger RMAppNodeUpdateEvent
private Boolean isRMAppEvent = false;
//Is trigger NodesListManagerEvent
private Boolean isNodesListEvent = false;
{noformat}
a) No need for comments
b) use ordinary "boolean" instead of "Boolean" (also, init to "false" is not
necessary, it is "false" by default because it's dictated by the JVM spec).
2.
{noformat}
Assert.assertFalse(getIsRMAppEvent());
Assert.assertTrue(getIsNodesListEvent());
{noformat}
Add some assertion message here, like
{noformat}
Assert.assertFalse("Got unexpected RM app event", getIsRMAppEvent());
Assert.assertTrue("Received no NodesListManagerEvent", getIsNodesListEvent());
{noformat}
3. Return values of {{getIsNodesListEvent()}} and {{getIsRMAppEvent()}} should
be just "boolean".
> NodeListManager event improvement
> ---------------------------------
>
> Key: YARN-9618
> URL: https://issues.apache.org/jira/browse/YARN-9618
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bibin Chundatt
> Assignee: Qi Zhu
> Priority: Critical
> Attachments: YARN-9618.001.patch, YARN-9618.002.patch,
> YARN-9618.003.patch, YARN-9618.004.patch, YARN-9618.005.patch,
> YARN-9618.006.patch
>
>
> Current implementation nodelistmanager event blocks async dispacher and can
> cause RM crash and slowing down event processing.
> # Cluster restart with 1K running apps . Each usable event will create 1K
> events over all events could be 5k*1k events for 5K cluster
> # Event processing is blocked till new events are added to queue.
> Solution :
> # Add another async Event handler similar to scheduler.
> # Instead of adding events to dispatcher directly call RMApp event handler.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
