[ 
https://issues.apache.org/jira/browse/YARN-10726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17313123#comment-17313123
 ] 

Peter Bacsko edited comment on YARN-10726 at 4/1/21, 12:01 PM:
---------------------------------------------------------------

Thanks [~zhuqi]. I think it's a good idea. My only concern (which might not be 
valid) is that we have too many events, this code can possibly run too 
frequently. For example, if you go 998, 998, 999, 1000, 1001, 1002, then it 
prints at 1000, then it starts to consume events, size goes back from 1000 to 
990, then it prints the size again.

I think we should limit how often we print this message. We should log it too 
often, I'm not sure how we do this in other parts of the code. I'll check what 
can be the best solution.


was (Author: pbacsko):
Thanks [~zhuqi]. I think it's a good idea. My only "concern" is that we have 
too many events, this code can possibly run too frequently. For example, if you 
go 998, 998, 999, 1000, 1001, 1002, then it prints at 1000, then it starts to 
consume events, size goes back from 1000 to 990, then it prints the size again.

I think we should limit how often we print this message. We should log it too 
often, I'm not sure how we do this in other parts of the code. I'll check what 
can be the best solution.

> Log the size of DelegationTokenRenewer event queue in case of too many 
> pending events
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-10726
>                 URL: https://issues.apache.org/jira/browse/YARN-10726
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Qi Zhu
>            Assignee: Qi Zhu
>            Priority: Major
>         Attachments: YARN-10726.001.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to