[
https://issues.apache.org/jira/browse/YARN-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326999#comment-17326999
]
Szilard Nemeth commented on YARN-10746:
---------------------------------------
Hi [~shuzirra],
Thanks for working on this.
First, could you please check the finbugs / Junit failures?
The production code is somewhat simple so I can't add a comment to that.
About the test code:
1. The method name "testStuff" is somewhat funny to me, but could it be a bit
more elaborate about what it tests ? :)
2. Javadoc of the new test method seems to be copied, doesn't apply to the
testcase.
The logic of the testcase looks good to me.
What is the requirement to return from the API if the default node label is not
set for a queue? I can't see a testcase for this. Is this intentional?
thanks.
> RmWebApp add default-node-label-expression to the queue info
> ------------------------------------------------------------
>
> Key: YARN-10746
> URL: https://issues.apache.org/jira/browse/YARN-10746
> Project: Hadoop YARN
> Issue Type: Task
> Reporter: Gergely Pollak
> Priority: Major
> Attachments: YARN-10746.001.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
