[
https://issues.apache.org/jira/browse/YARN-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329183#comment-17329183
]
Gergely Pollak commented on YARN-10654:
---------------------------------------
[~pbacsko] thank you for the patch, LGTM+1 (Non-binding)
You integrated the change really smoothly into the placement engine, I don't
see any possible issues with it. I really like how we keep the original user
name for all logging purposes, and only change it in the variable context.
Perhaps in the future we might need to make the replacement string
configurable, but now it works like FS does, which is fine for now I think.
> Dots '.' in CSMappingRule path variables should be replaced
> -----------------------------------------------------------
>
> Key: YARN-10654
> URL: https://issues.apache.org/jira/browse/YARN-10654
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Gergely Pollak
> Assignee: Peter Bacsko
> Priority: Major
> Attachments: YARN-10654-001.patch
>
>
> Dots are used as separators, so we should escape them somehow in the
> variables when substituting them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
