[ https://issues.apache.org/jira/browse/YARN-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17335401#comment-17335401 ]
Bilwa S T commented on YARN-10745: ---------------------------------- Hi [~dmmkr] Thanks for the patch. I have few minor comments * In ProportionalCapacityPreemptionPolicy.java LOG.isDebugEnabled() check can be removed for below log {quote} LOG.debug("Send to scheduler: in app={} " + "#containers-to-be-preemptionCandidates={}", appAttemptId, e.getValue().size()); {quote} * Why do we need LOG.isDebugEnabled() check in AsyncDispatcher.java Few suggestions * In NodesListManager.java we can print below log only if either of the sets is not empty {quote} LOG.info("hostsReader include:\{" +StringUtils.join(",", hostsReader.getHosts()) +"} exclude:{" + StringUtils.join(",", hostsReader.getExcludedHosts()) + "}"); {quote} > Change Log level from info to debug for few logs and remove unnecessary > debuglog checks > --------------------------------------------------------------------------------------- > > Key: YARN-10745 > URL: https://issues.apache.org/jira/browse/YARN-10745 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: D M Murali Krishna Reddy > Assignee: D M Murali Krishna Reddy > Priority: Minor > Attachments: YARN-10745.001.patch > > > Change the info log level to debug for few logs so that the load on the > logger decreases in large cluster and improves the performance. > Remove the unnecessary isDebugEnabled() checks for printing strings without > any string concatenation -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org