[ 
https://issues.apache.org/jira/browse/YARN-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342269#comment-17342269
 ] 

Qi Zhu commented on YARN-10759:
-------------------------------

Thanks [~gandras] for this work.

Very good work, i am very appreciate you can make the code more clear.

LGTM +1  Just fix the checkstyle.

> Encapsulate queue config modes
> ------------------------------
>
>                 Key: YARN-10759
>                 URL: https://issues.apache.org/jira/browse/YARN-10759
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Major
>         Attachments: YARN-10759.001.patch, YARN-10759.002.patch, 
> YARN-10759.003.patch
>
>
> Capacity Scheduler queues have three modes:
>  * relative/percentage
>  * weight
>  * absolute
> Most of them have their own:
>  * validation logic
>  * config setting logic
>  * effective capacity calculation logic
> These logics can be easily extracted and encapsulated in separate config mode 
> classes. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to