[ 
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342360#comment-17342360
 ] 

Peter Bacsko commented on YARN-10763:
-------------------------------------

[~chaosju] some comments:

1. {{Timer}} / {{TimerTask}} are rather old constructs, I'd prefer 
{{ScheduledThreadPoolExecutor}}.
2. Another problem is that the {{Timer}} is not stopped in {{destroy()}}, this 
can definitely be a problem in the tests.
3. This is a singleton class, so the constructor should not be public, so 
remove the modifier.


> add  the speed of containers assigned metrics to ClusterMetrics
> ---------------------------------------------------------------
>
>                 Key: YARN-10763
>                 URL: https://issues.apache.org/jira/browse/YARN-10763
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 3.2.1
>            Reporter: chaosju
>            Priority: Major
>         Attachments: YARN-10763.001.patch, screenshot-1.png
>
>
> It'd be good to have ContainerAssignedNum/Second in ClusterMetrics for 
> measuring cluster throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to