[ 
https://issues.apache.org/jira/browse/YARN-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833305#comment-13833305
 ] 

Sandy Ryza commented on YARN-1241:
----------------------------------

Uploaded a patch that adds the requested tests, code changes, and documentation.

bq. Not particular on it, but would be nice to move 
TestCapacityScheduler#verifyConcurrentAccessOnApplications out of 
TestCapacityScheduler - may be SchedulerTestUtils or something?
Definitely agree, but I think this is work for a different JIRA.

bq. Probably inconsequential, should queue.addApp be after tracking the app 
below:
It needs to be the way it is because of how apps are initialized in queues.  
The queue creates the AppSchedulable from the FSSchedulerApp and places it in 
the FSSchedulerApp.  This could maybe be cleaned up but I think this is also 
work for a separate JIRA.

> In Fair Scheduler maxRunningApps does not work for non-leaf queues
> ------------------------------------------------------------------
>
>                 Key: YARN-1241
>                 URL: https://issues.apache.org/jira/browse/YARN-1241
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.1.0-beta
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: YARN-1241-1.patch, YARN-1241-10.patch, 
> YARN-1241-2.patch, YARN-1241-3.patch, YARN-1241-4.patch, YARN-1241-5.patch, 
> YARN-1241-6.patch, YARN-1241-7.patch, YARN-1241-8.patch, YARN-1241-9.patch, 
> YARN-1241.patch
>
>
> Setting the maxRunningApps property on a parent queue should make it that the 
> sum of apps in all subqueues can't exceed it



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to