[jira] [Commented] (YARN-10763) add the speed of containers assigned metrics to ClusterMetrics

[Peter Bacsko (Jira)]

    [ 
https://issues.apache.org/jira/browse/YARN-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344518#comment-17344518
 ] 

Peter Bacsko commented on YARN-10763:
-------------------------------------

Thanks [~chaosju] just a final update, very minor things:

1. "Containers assigned in last second" --> missing "the": "Containers assigned 
in *the* last second"

2. Comment is not necessary, purpose of the executor is trivial:
{noformat}
          /**
           * The executor service that count containers assigned in last second.
           *
           */
{noformat}

3. Nit: space after if
{noformat}
            if(INSTANCE != null && INSTANCE.getAssignCounterExecutor() != null) 
{
              INSTANCE.getAssignCounterExecutor().shutdownNow();
            }
{noformat}

I have no further comments.

> add  the speed of containers assigned metrics to ClusterMetrics
> ---------------------------------------------------------------
>
>                 Key: YARN-10763
>                 URL: https://issues.apache.org/jira/browse/YARN-10763
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: chaosju
>            Assignee: chaosju
>            Priority: Minor
>         Attachments: YARN-10763.001.patch, YARN-10763.002.patch, 
> YARN-10763.003.patch, YARN-10763.004.patch, YARN-10763.005.patch, 
> YARN-10763.006.patch, YARN-10763.007.patch, screenshot-1.png
>
>
> It'd be good to have ContainerAssignedNum/Second in ClusterMetrics for 
> measuring cluster throughput.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org