[ 
https://issues.apache.org/jira/browse/YARN-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348147#comment-17348147
 ] 

Peter Bacsko edited comment on YARN-10779 at 5/20/21, 8:33 AM:
---------------------------------------------------------------

"It is a possibility that Node A sends this PB message to Node B, which means 
that this configuration must be set on Node B in order to take effect"

What you're saying is true, but this applies to the whole Hadoop ecosystem, not 
just to this particular setting. Imagine having different container executors 
on different nodes, or security enabled/disabled, that would wreak havoc. 
Proper configuration management is mandatory and assumed.


was (Author: pbacsko):
"It is a possibility that Node A sends this PB message to Node B, which means 
that this configuration must be set on Node B in order to take effect"

What you're saying is true, but this applies to the whole Hadoop ecosystem, not 
just to this particular setting. Imagine having different container executors 
on different nodes, or security enabled/disabled, that would wreak havoc. 
Proper configuration management is a mandatory and assumed.

> Add option to disable lowercase conversion in GetApplicationsRequestPBImpl 
> and ApplicationSubmissionContextPBImpl
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-10779
>                 URL: https://issues.apache.org/jira/browse/YARN-10779
>             Project: Hadoop YARN
>          Issue Type: Task
>          Components: resourcemanager
>            Reporter: Peter Bacsko
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-10779-POC.patch
>
>
> In both {{GetApplicationsRequestPBImpl}} and 
> {{ApplicationSubmissionContextPBImpl}}, there is a forced lowercase 
> conversion:
> {noformat}
>     checkTags(tags);
>     // Convert applicationTags to lower case and add
>     this.applicationTags = new TreeSet<>();
>     for (String tag : tags) {
>       this.applicationTags.add(StringUtils.toLowerCase(tag));
>     }
>   }
> {noformat}
> However, we encountered some cases where this is not desirable for "userid" 
> tags. 
> Proposed solution: since both classes are pretty low-level and can be often 
> instantiated, a {{Configuration}} object which loads {{yarn-site.xml}} should 
> be cached inside them. A new property should be created which tells whether 
> lowercase conversion should occur or not.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to