[ https://issues.apache.org/jira/browse/YARN-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349021#comment-17349021 ]
Andras Gyori commented on YARN-10779: ------------------------------------- Thank you [~pbacsko] for the new revision. I have one question: * the lowerCase boolean is a static variable hence it is only evaluated once. I think in the following scenario the lowerCase variable will remain true: ** Initially lowerCase property is not set, thus evaluates to true by default ** user set lowerCase property to false, reinitialises CS ** since the static lowerCase is already set for all ApplicationSubmissionPBImpl, it is not reevaluated to false > Add option to disable lowercase conversion in GetApplicationsRequestPBImpl > and ApplicationSubmissionContextPBImpl > ----------------------------------------------------------------------------------------------------------------- > > Key: YARN-10779 > URL: https://issues.apache.org/jira/browse/YARN-10779 > Project: Hadoop YARN > Issue Type: Task > Components: resourcemanager > Reporter: Peter Bacsko > Assignee: Peter Bacsko > Priority: Major > Attachments: YARN-10779-001.patch, YARN-10779-002.patch, > YARN-10779-003.patch, YARN-10779-POC.patch > > > In both {{GetApplicationsRequestPBImpl}} and > {{ApplicationSubmissionContextPBImpl}}, there is a forced lowercase > conversion: > {noformat} > checkTags(tags); > // Convert applicationTags to lower case and add > this.applicationTags = new TreeSet<>(); > for (String tag : tags) { > this.applicationTags.add(StringUtils.toLowerCase(tag)); > } > } > {noformat} > However, we encountered some cases where this is not desirable for "userid" > tags. > Proposed solution: since both classes are pretty low-level and can be often > instantiated, a {{Configuration}} object which loads {{yarn-site.xml}} should > be cached inside them. A new property should be created which tells whether > lowercase conversion should occur or not. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org