[
https://issues.apache.org/jira/browse/YARN-10663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389977#comment-17389977
]
Szilard Nemeth commented on YARN-10663:
---------------------------------------
Hi [~ananyo_rao],
Thanks for working on this.
Latest patch LGTM, committed to trunk.
One side note:
Please set up your code formatter rules in your IDE, I fixed some formatting
issues like missing spaces after for/while loop expressions, indentation level
fixes for multi-line expressions and such kind of things.
If you would like to get help for the rules I can help you offline.
For reference, these were the checkstyle issues reported by Jenkins:
{code}
./hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NMSimulator.java:274:
&& !getNode().getRunningApps().contains(applicationId)) {: '&&' has
incorrect indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NMSimulator.java:278:
"Updated runningApps on this node are: {}",: '"Updated runningApps on
this node are: {}"' has incorrect indentation level 6, expected level should be
8. [Indentation]
./hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NMSimulator.java:279:
applicationId, getNode().getNodeID(), getNode().getRunningApps());:
'applicationId' has incorrect indentation level 6, expected level should be 8.
[Indentation]
./hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/nodemanager/NMSimulator.java:315:
applicationId, getNode().getNodeID(), getNode().getRunningApps());:
'applicationId' has incorrect indentation level 8, expected level should be 10.
[Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/appmaster/TestAMSimulator.java:308:
app.appId = ApplicationId.newInstance(0l, 1);:43: Should use uppercase 'L'.
[UpperEll]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:114:
node1.addNewContainer(container1, 100000l, null);:39: Should use uppercase
'L'. [UpperEll]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:122:
node1.addNewContainer(container2, -1l, null);:40: Should use uppercase 'L'.
[UpperEll]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:147:
rm, -1f);: 'rm' has incorrect indentation level 6, expected level should
be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:160:
GenericTestUtils.waitFor(new
org.apache.hadoop.thirdparty.com.google.common.base.Supplier<Boolean>() {: Line
is longer than 100 characters (found 106). [LineLength]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:168:
node.getNode().getRunningApps().size(), 0);: 'node' has incorrect
indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:175:
Resources.createResource(GB, 1), null, null);: 'Resources' has incorrect
indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:176:
node.addNewContainer(container, 100000l, appId);:37: Should use uppercase
'L'. [UpperEll]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:179:
node.getNode().getRunningApps().contains(appId));: 'node' has incorrect
indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:187:
node.getNode().getRunningApps().size(), 0);: 'node' has incorrect
indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:195:
rm, -1f);: 'rm' has incorrect indentation level 6, expected level should
be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:208:
GenericTestUtils.waitFor(new
org.apache.hadoop.thirdparty.com.google.common.base.Supplier<Boolean>() {: Line
is longer than 100 characters (found 106). [LineLength]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:216:
node.getNode().getRunningApps().size(), 0);: 'node' has incorrect
indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:221:
Resources.createResource(GB, 1), null, null);: 'Resources' has incorrect
indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:222:
node.addNewContainer(container, 100000l, null);:37: Should use uppercase
'L'. [UpperEll]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:224:
node.getNode().getRunningApps().size(), 0);: 'node' has incorrect
indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-sls/src/test/java/org/apache/hadoop/yarn/sls/nodemanager/TestNMSimulator.java:230:
node.getNode().getRunningApps().size(), 0);: 'node' has incorrect
indentation level 6, expected level should be 8. [Indentation]
{code}
> Add runningApps stats in SLS
> ----------------------------
>
> Key: YARN-10663
> URL: https://issues.apache.org/jira/browse/YARN-10663
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: VADAGA ANANYO RAO
> Assignee: VADAGA ANANYO RAO
> Priority: Major
> Attachments: YARN-10663.0001.patch, YARN-10663.0002.patch
>
>
> RMNodes in SLS don't keep a track of runningApps on each node. Due to this,
> graceful decommissioning logic takes a hit as the nodes will decommission if
> there are no running containers on the node but some shuffle data was present
> on the node.
> In this Jira, we will add runningApps functionality in SLS for improving
> decommissioning logic of each node. This will help with autoscaling
> simulations on SLS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
