[
https://issues.apache.org/jira/browse/YARN-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836701#comment-13836701
]
Zhijie Shen commented on YARN-1445:
-----------------------------------
1. I agree on the most plans about dealing with FINISHING.
bq. 3.WebAppProxyServlet::doGet(). I think we might need to handle FINISHING as
well as FINISHED.
After RMApp enters FINISHING, the AM has already been unregistered, and
tracking url has already been updated. Therefore, we're able to redirect the
request in this state.
bq. 5.ClientServiceDelegate::getProxy(), we might need to handle
YarnApplicationState.FINISHING, too.
When the application is in FINISHING, the AM has already been unregistered, and
MR job need to be redirected to JHS for the details.
bq. 6.ApplicationCLI::killApplication(). Here is a question mark. We can kill
the AM when the RMApp is at Finishing state, since the AM did not really exist.
Just for DS and MR, when the AM did the unregisterApplicationMaster, that means
the application is finished, so at this time, if we send kill event, it is
meaningless. Here, I just handle the YarnApplicationState.Finishing and
Finished with the same way.
I've the different opinion here. RMAppImpl actually allows killing the app when
it is in FINISHING. Moreover, if we handle FINISHING in the same way as
FINISHED, we will see that printApplicationReport tells the app is still in
FINISHING, while killApplication says the app is finished. Thoughts?
2. TestYarnClient#testSubmitApplication need to be changed accordingly as well.
Would you please double check other test classes where FINISHED is referred,
and check whether the test cases will be broken or not?
3. Is it good to document the difference in detail between FINISHING and
FINISHED?
> Separate FINISHING and FINISHED state in YarnApplicationState
> -------------------------------------------------------------
>
> Key: YARN-1445
> URL: https://issues.apache.org/jira/browse/YARN-1445
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-1445.1.patch, YARN-1445.2.patch
>
>
> Today, we will transmit both RMAppState.FINISHING and RMAppState.FINISHED to
> YarnApplicationState.FINISHED.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
