[ https://issues.apache.org/jira/browse/YARN-10950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417328#comment-17417328 ]
Szilard Nemeth commented on YARN-10950: --------------------------------------- Hi [~adam.antal], Sure, just merged your PR. Thanks for your contribution. > Code cleanup in QueueCapacities > ------------------------------- > > Key: YARN-10950 > URL: https://issues.apache.org/jira/browse/YARN-10950 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Szilard Nemeth > Assignee: Adam Antal > Priority: Minor > Labels: pull-request-available > Fix For: 3.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > > - Make fields final: capacitiesMap, readLock, writeLock > - Remove explicit type arguments, e.g. new HashMap<String, Capacities>(); > - Remove abbrevations and avoid string concatenation in > QueueCapacities.Capacities#toString > - Remove unnecessary comments, e.g. "/* Used Capacity Getter and Setter */" & > "/* Absolute Used Capacity Getter and Setter */" > - And probably many more.. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org