[ 
https://issues.apache.org/jira/browse/YARN-10968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419613#comment-17419613
 ] 

Hadoop QA commented on YARN-10968:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime ||  Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  8s{color} 
| {color:red}{color} | {color:red} YARN-10968 does not apply to trunk. Rebase 
required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for 
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-10968 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13034090/YARN-10968.002.patch |
| Console output | 
https://ci-hadoop.apache.org/job/PreCommit-YARN-Build/1213/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |


This message was automatically generated.



> SchedulingRequests can be wrong when multiple containers stopped at the same 
> time
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-10968
>                 URL: https://issues.apache.org/jira/browse/YARN-10968
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.1.2
>            Reporter: Lee young gon
>            Priority: Major
>         Attachments: YARN-10968.001.patch, YARN-10968.002.patch
>
>
> There are two ways to request containers to RM through AMRMClientImpl.
>  # addContainerRequest
>  # addSchedulingRequests
> These two requests are linked to each parameter in Scheduler's allocate()
> {code:java}
> # addContainerRequest <-> ask
> # addSchedulingRequests  <->  schedulingRequestspublic Allocation 
> allocate(ApplicationAttemptId applicationAttemptId,
>       List<ResourceRequest> ask, List<SchedulingRequest> schedulingRequests,
>       List<ContainerId> release, List<String> blacklistAdditions,
>       List<String> blacklistRemovals, ContainerUpdates updateRequests) {
>     FiCaSchedulerApp application = 
> getApplicationAttempt(applicationAttemptId);
> {code}
>  
> We are using yarn-service and placement_policy, in which case 
> addSchedulingRequests is used.
> AddSchedulingRequests have the problems.
> When two containers are terminated at the same time in the presence of a 
> placement_policy, AM requests a submitting scheduling request twice as 
> follows.
> {code:java}
> 2021-03-31 17:56:07,485 [Component  dispatcher] INFO  component.Component - 
> [COMPONENT sleep] Requesting for 1 container(s)
> 2021-03-31 17:56:07,485 [Component  dispatcher] INFO  component.Component - 
> [COMPONENT sleep] Submitting scheduling request: 
> SchedulingRequestPBImpl{priority=0, allocationReqId=0, 
> executionType={Execution Type: GUARANTEED, Enforce Execution Type: true}, 
> allocationTags=[testapp], 
> resourceSizing=ResourceSizingPBImpl{numAllocations=1, resources=<memory:512, 
> vCores:1>}, 
> placementConstraint=notin,node,yarn_node_partition/=[test2]:notin,node,testapp}2021-03-31
>  17:56:07,486 [Component  dispatcher] INFO  component.Component - [COMPONENT 
> sleep] Requesting for 1 container(s)
> 2021-03-31 17:56:07,487 [Component  dispatcher] INFO  component.Component - 
> [COMPONENT sleep] Submitting scheduling request: 
> SchedulingRequestPBImpl{priority=0, allocationReqId=0, 
> executionType={Execution Type: GUARANTEED, Enforce Execution Type: true}, 
> allocationTags=[testapp], 
> resourceSizing=ResourceSizingPBImpl{numAllocations=1, resources=<memory:512, 
> vCores:1>}, 
> placementConstraint=notin,node,yarn_node_partition/=[test2]:notin,node,testapp}
>  {code}
> And this comes to RM at each request.
> Then if the above request is received, the 
> SingleConstrainAppPlaceAllocatorwill have only the last value.
> In other words, if multiple containers die at the same time, multiple 
> requests are created, and RM accepts only the final one request and allocates 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to