[ https://issues.apache.org/jira/browse/YARN-11240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582671#comment-17582671 ]
ASF GitHub Bot commented on YARN-11240: --------------------------------------- ayushtkn commented on code in PR #4678: URL: https://github.com/apache/hadoop/pull/4678#discussion_r950919833 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/ServiceScheduler.java: ########## @@ -1139,7 +1139,7 @@ public void syncSysFs(Service yarnApp) { LOG.info("YARN sysfs synchronized."); } } catch (IOException | URISyntaxException | InterruptedException e) { - LOG.error("Fail to sync service spec: {}", e); + LOG.error("Fail to sync service spec: {}", e.getMessage(), e); Review Comment: No need to keep the message, just e is enough ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestServiceAM.java: ########## @@ -553,7 +553,7 @@ public void testSyncSysFS() { am.stop(); am.close(); } catch (Exception e) { - LOG.error("Fail to sync sysfs: {}", e); + LOG.error("Fail to sync sysfs: {}", e.getMessage(), e); Review Comment: Keep only e, message will come as part of that > Fix incorrect placeholder in yarn-module > ---------------------------------------- > > Key: YARN-11240 > URL: https://issues.apache.org/jira/browse/YARN-11240 > Project: Hadoop YARN > Issue Type: Improvement > Affects Versions: 3.4.0 > Reporter: fanshilun > Assignee: fanshilun > Priority: Minor > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Try to deal with the moudle problem at a time. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org