[ https://issues.apache.org/jira/browse/YARN-11177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584606#comment-17584606 ]
ASF GitHub Bot commented on YARN-11177: --------------------------------------- slfan1989 commented on code in PR #4764: URL: https://github.com/apache/hadoop/pull/4764#discussion_r954499120 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java: ########## @@ -1624,6 +1788,35 @@ protected SubClusterId getApplicationHomeSubCluster( throw new YarnException(errorMsg); } + protected SubClusterId getReservationHomeSubCluster(ReservationId reservationId) + throws YarnException { + + if (reservationId == null) { + LOG.error("ReservationId is Null, Can't find in SubCluster."); + return null; + } + + SubClusterId resultSubClusterId = null; + + // try looking for applicationId in Home SubCluster + try { + resultSubClusterId = federationFacade.getReservationHomeSubCluster(reservationId); + } catch (YarnException ex) { + if(LOG.isDebugEnabled()){ + LOG.debug("Can't find reservationId = {} in home sub cluster, " + + " try foreach sub clusters.", reservationId); Review Comment: I will fix it. ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java: ########## @@ -203,6 +218,12 @@ protected YarnConfiguration createConfiguration() { // Disable StateStoreFacade cache conf.setInt(YarnConfiguration.FEDERATION_CACHE_TIME_TO_LIVE_SECS, 0); + + conf.setInt("yarn.scheduler.minimum-allocation-mb", 512); + conf.setInt("yarn.scheduler.minimum-allocation-vcores", 1); + conf.setInt("yarn.scheduler.maximum-allocation-mb", 102400); Review Comment: I will fix it. > Support getNewReservation, submitReservation, updateReservation, > deleteReservation API's for Federation > ------------------------------------------------------------------------------------------------------- > > Key: YARN-11177 > URL: https://issues.apache.org/jira/browse/YARN-11177 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: fanshilun > Assignee: fanshilun > Priority: Major > Labels: pull-request-available > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org