[
https://issues.apache.org/jira/browse/YARN-11177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585627#comment-17585627
]
ASF GitHub Bot commented on YARN-11177:
---------------------------------------
slfan1989 commented on code in PR #4764:
URL: https://github.com/apache/hadoop/pull/4764#discussion_r956480233
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -1614,13 +1782,41 @@ protected SubClusterId getApplicationHomeSubCluster(
} catch (Exception ex) {
if(LOG.isDebugEnabled()){
- LOG.debug("Can't Find ApplicationId = {} in Sub Cluster!",
applicationId);
+ LOG.debug("Can't find applicationId = {} in Sub Cluster!",
applicationId);
}
}
}
String errorMsg =
- String.format("Can't Found applicationId = %s in any sub clusters",
applicationId);
+ String.format("Can't find applicationId = %s in any sub clusters",
applicationId);
+ throw new YarnException(errorMsg);
+ }
+
+ protected SubClusterId getReservationHomeSubCluster(ReservationId
reservationId)
+ throws YarnException {
+
+ if (reservationId == null) {
+ LOG.error("ReservationId is Null, Can't find in SubCluster.");
+ return null;
+ }
+
+ SubClusterId resultSubClusterId = null;
+
+ // try looking for reservation in Home SubCluster
+ try {
+ resultSubClusterId =
federationFacade.getReservationHomeSubCluster(reservationId);
+ } catch (YarnException ex) {
+ if(LOG.isDebugEnabled()){
Review Comment:
I will modify the code.
> Support getNewReservation, submitReservation, updateReservation,
> deleteReservation API's for Federation
> -------------------------------------------------------------------------------------------------------
>
> Key: YARN-11177
> URL: https://issues.apache.org/jira/browse/YARN-11177
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
