[ https://issues.apache.org/jira/browse/YARN-11273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597507#comment-17597507 ]
ASF GitHub Bot commented on YARN-11273: --------------------------------------- slfan1989 commented on code in PR #4817: URL: https://github.com/apache/hadoop/pull/4817#discussion_r957975795 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java: ########## @@ -1016,30 +1035,275 @@ private static byte[] getByteArray(ByteBuffer bb) { @Override public AddReservationHomeSubClusterResponse addReservationHomeSubCluster( Review Comment: Thank you for your suggestion. I will explain this part of the test: We are in YARN-11272, we implemented store Reservations in ZK, in this pr we defined the test of the method in FederationStateStoreBaseTest.java ``` testAddReservationHomeSubCluster() testAddReservationHomeSubClusterReservationAlreadyExists() testAddReservationHomeSubClusterAppAlreadyExistsInTheSameSC() testDeleteReservationHomeSubCluster() testDeleteReservationHomeSubClusterUnknownApp() testUpdateReservationHomeSubCluster() ``` Because TestSQLFederationStateStore extends FederationStateStoreBaseTest, we can reuse YARN-11272 tests, and of course we will add some tests. > [RESERVATION] Federation StateStore: Support storage/retrieval of > Reservations With SQL > --------------------------------------------------------------------------------------- > > Key: YARN-11273 > URL: https://issues.apache.org/jira/browse/YARN-11273 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation > Affects Versions: 3.4.0 > Reporter: fanshilun > Assignee: fanshilun > Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org