[ 
https://issues.apache.org/jira/browse/YARN-11286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602236#comment-17602236
 ] 

ASF GitHub Bot commented on YARN-11286:
---------------------------------------

slfan1989 commented on code in PR #4824:
URL: https://github.com/apache/hadoop/pull/4824#discussion_r966873332


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/event/AsyncDispatcher.java:
##########
@@ -189,10 +189,24 @@ protected void serviceInit(Configuration conf) throws 
Exception{
     ThreadFactory threadFactory = new ThreadFactoryBuilder()
         .setNameFormat("PrintEventDetailsThread #%d")
         .build();
+

Review Comment:
   Thank you very much for helping to review the code, I will modify the code.





> Make AsyncDispatcher#printEventDetailsExecutor thread pool parameter 
> configurable
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-11286
>                 URL: https://issues.apache.org/jira/browse/YARN-11286
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 3.4.0
>            Reporter: fanshilun
>            Assignee: fanshilun
>            Priority: Minor
>              Labels: pull-request-available
>
> AsyncDispatcher#printEventDetailsExecutor thread pool parameters are 
> hard-coded, extract this part of hard-coded configuration parameters to the 
> configuration file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to