[ https://issues.apache.org/jira/browse/YARN-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605709#comment-17605709 ]
ASF GitHub Bot commented on YARN-11305: --------------------------------------- slfan1989 commented on code in PR #4893: URL: https://github.com/apache/hadoop/pull/4893#discussion_r972762585 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java: ########## @@ -252,7 +252,7 @@ private void verifyLocalFileDeletion( count = 0; while ((f.exists()) && (count < maxAttempts)) { count++; - Thread.sleep(100); + Thread.sleep(1000); Review Comment: Thank you very much for your help reviewing the code, I will use `GenericTestUtils.waitFor` for code refactoring. > Fix TestLogAggregationService#testLocalFileDeletionAfterUpload Failed After > YARN-11241(#4703) > --------------------------------------------------------------------------------------------- > > Key: YARN-11305 > URL: https://issues.apache.org/jira/browse/YARN-11305 > Project: Hadoop YARN > Issue Type: Bug > Components: log-aggregation > Affects Versions: 3.4.0 > Reporter: fanshilun > Assignee: fanshilun > Priority: Major > Labels: pull-request-available > > Yarn's unit tests, with parallel mode enabled > {code:java} > /usr/bin/mvn --batch-mode > -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-4846/yetus-m2/hadoop-trunk-patch-0 > -Ptest-patch -Dsurefire.rerunFailingTestsCount=2 -Pparallel-tests > -P!shelltest -Pnative -Drequire.fuse -Drequire.openssl -Drequire.snappy > -Drequire.valgrind -Drequire.zstd -Drequire.test.libhadoop -Pyarn-ui clean > test -fae{code} > Because the automatically generated application_id is the same, > *testLocalFileDeletionAfterUpload* is affected by > *testLocalFileRemainsAfterUploadOnCleanupDisable* > testLocalFileDeletionAfterUpload needs to check that the log of an > application is deleted, and testLocalFileRemainsAfterUploadOnCleanupDisable > regenerates the log of the same application. > Error Message > {code:java} > Directory > [/home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-4846/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/target/TestLogAggregationService-localLogDir/application_1234_0001] > was not deleted {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org