[ https://issues.apache.org/jira/browse/YARN-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605966#comment-17605966 ]
ASF GitHub Bot commented on YARN-11226: --------------------------------------- slfan1989 commented on code in PR #4892: URL: https://github.com/apache/hadoop/pull/4892#discussion_r973327713 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java: ########## @@ -142,6 +154,23 @@ public void setUp() { Assert.fail(); } + try { + for (SubClusterId subCluster : subClusters) { + SubClusterInfo subClusterInfo = stateStoreUtil.querySubClusterInfo(subCluster); + interceptor.getOrCreateInterceptorForSubCluster( + subCluster, subClusterInfo.getRMWebServiceAddress()); + } + } catch (YarnException e) { Review Comment: Thanks for your help reviewing the code, I will fix it. ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/webapp/TestFederationInterceptorREST.java: ########## @@ -142,6 +154,23 @@ public void setUp() { Assert.fail(); } + try { + for (SubClusterId subCluster : subClusters) { + SubClusterInfo subClusterInfo = stateStoreUtil.querySubClusterInfo(subCluster); + interceptor.getOrCreateInterceptorForSubCluster( + subCluster, subClusterInfo.getRMWebServiceAddress()); + } + } catch (YarnException e) { + LOG.error(e.getMessage()); + Assert.fail(); + } + + try { + interceptor.setupResourceManager(); + } catch (Exception e) { Review Comment: I will fix it. > [Federation] Add createNewReservation, submitReservation, updateReservation, > deleteReservation REST APIs for Router > ------------------------------------------------------------------------------------------------------------------- > > Key: YARN-11226 > URL: https://issues.apache.org/jira/browse/YARN-11226 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation > Affects Versions: 3.4.0, 3.3.4 > Reporter: fanshilun > Assignee: fanshilun > Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org