[ 
https://issues.apache.org/jira/browse/YARN-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17610102#comment-17610102
 ] 

ASF GitHub Bot commented on YARN-11318:
---------------------------------------

slfan1989 commented on PR #4939:
URL: https://github.com/apache/hadoop/pull/4939#issuecomment-1259619279

   @goiri Can you help review this pr? Thank you very much!




> Improve FederationInterceptorREST#createInterceptorForSubCluster Use 
> WebAppUtils
> --------------------------------------------------------------------------------
>
>                 Key: YARN-11318
>                 URL: https://issues.apache.org/jira/browse/YARN-11318
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: federation, router
>    Affects Versions: 3.4.0
>            Reporter: fanshilun
>            Assignee: fanshilun
>            Priority: Major
>              Labels: pull-request-available
>
> FederationInterceptorREST#createInterceptorForSubCluster
>  
> {code:java}
> private DefaultRequestInterceptorREST createInterceptorForSubCluster(
>     SubClusterId subClusterId, String webAppAddress) {
>   .....
>   interceptorInstance.setWebAppAddress("http://"; + webAppAddress);
>   .....
> } {code}
>  
> setWebAppAddress should not use http directly, the prefix should be confirmed 
> according to the policy.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to