[ https://issues.apache.org/jira/browse/YARN-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611006#comment-17611006 ]
ASF GitHub Bot commented on YARN-6169: -------------------------------------- hadoop-yetus commented on PR #4952: URL: https://github.com/apache/hadoop/pull/4952#issuecomment-1262212331 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 41m 20s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 43m 46s | | trunk passed | | +1 :green_heart: | compile | 1m 48s | | trunk passed | | +1 :green_heart: | mvnsite | 1m 1s | | trunk passed | | +1 :green_heart: | shadedclient | 67m 53s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 42s | | the patch passed | | +1 :green_heart: | compile | 1m 22s | | the patch passed | | +1 :green_heart: | cc | 1m 22s | | the patch passed | | +1 :green_heart: | golang | 1m 22s | | the patch passed | | +1 :green_heart: | javac | 1m 22s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | mvnsite | 0m 45s | | the patch passed | | +1 :green_heart: | shadedclient | 20m 51s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 24m 31s | | hadoop-yarn-server-nodemanager in the patch passed. | | +1 :green_heart: | asflicense | 0m 45s | | The patch does not generate ASF License warnings. | | | | 159m 24s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4952/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4952 | | Optional Tests | dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang | | uname | Linux 3012be45537a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 4c13ee23c0c0dfdecbb3ed1bbbe5f47d76c40d55 | | Default Java | Red Hat, Inc.-1.8.0_345-b01 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4952/1/testReport/ | | Max. process+thread count | 553 (vs. ulimit of 5500) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4952/1/console | | versions | git=2.9.5 maven=3.6.3 | | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org | This message was automatically generated. > container-executor message on empty configuration file can be improved > ---------------------------------------------------------------------- > > Key: YARN-6169 > URL: https://issues.apache.org/jira/browse/YARN-6169 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Miklos Szegedi > Assignee: Riya Khandelwal > Priority: Trivial > Labels: newbie, pull-request-available, trivial > > If the configuration file is empty, we get the following error message: > {{Invalid configuration provided in /root/etc/hadoop/container-executor.cfg}} > This is does not provide enough details to figure out what is the issue at > the first glance. We should use something like 'Empty configuration file > provided...' > {code} > if (cfg->size == 0) { > fprintf(ERRORFILE, "Invalid configuration provided in %s\n", file_name); > exit(INVALID_CONFIG_FILE); > } > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org