[ https://issues.apache.org/jira/browse/YARN-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636073#comment-17636073 ]
ASF GitHub Bot commented on YARN-11350: --------------------------------------- slfan1989 commented on PR #5131: URL: https://github.com/apache/hadoop/pull/5131#issuecomment-1320648545 > Thanks @slfan1989 , Great work here! > One concern out of this PR, we have HDFS RBF / YARN Federation / KMS both depend on zookeeper to store DelegationToken. From my view, both of their logic are similar, we should consider implement one common module about ZKDelegationTokenManager? Thus it will reduce overhead to implement at each sub-project side. WDYT? cc @goiri > NOTE: This is not blocker comments. Thanks. Thank you very much for your suggestion, I agree with your idea. After completing this pr, I will continue to carefully read the codes of the HDFS RBF / KMS modules about delegation, and then extract this part of the code to the common module. If other modules need it, we will can be used directly. > [Federation] Router Support DelegationToken With ZK > --------------------------------------------------- > > Key: YARN-11350 > URL: https://issues.apache.org/jira/browse/YARN-11350 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation, router > Affects Versions: 3.4.0 > Reporter: fanshilun > Assignee: fanshilun > Priority: Major > Labels: pull-request-available > > [Federation] Router Support DelegationToken With > ZookeeperFederationStateStore. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org