[
https://issues.apache.org/jira/browse/YARN-11374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646735#comment-17646735
]
ASF GitHub Bot commented on YARN-11374:
---------------------------------------
goiri commented on code in PR #5193:
URL: https://github.com/apache/hadoop/pull/5193#discussion_r1047443121
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
##########
@@ -192,11 +192,11 @@ public RefreshQueuesResponse
refreshQueues(RefreshQueuesRequest request)
}
} catch (YarnException e) {
routerMetrics.incrRefreshQueuesFailedRetrieved();
- RouterServerUtil.logAndThrowException(e, "Unable to refreshQueue due to
exception.");
+ throw e;
}
routerMetrics.incrRefreshQueuesFailedRetrieved();
- throw new YarnException("Unable to refreshQueue.");
+ throw new YarnException("Unable to refreshQueue due to exception.");
Review Comment:
Do we need to change this?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
##########
@@ -192,11 +192,11 @@ public RefreshQueuesResponse
refreshQueues(RefreshQueuesRequest request)
}
} catch (YarnException e) {
routerMetrics.incrRefreshQueuesFailedRetrieved();
- RouterServerUtil.logAndThrowException(e, "Unable to refreshQueue due to
exception.");
+ throw e;
Review Comment:
No log anymore?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/RefreshSuperUserGroupsConfigurationRequestPBImpl.java:
##########
@@ -56,8 +59,9 @@ public int hashCode() {
@Override
public boolean equals(Object other) {
- if (other == null)
+ if (other == null) {
return false;
+ }
if (other.getClass().isAssignableFrom(this.getClass())) {
return this.getProto().equals(this.getClass().cast(other).getProto());
Review Comment:
We had a cleaner way to do all this check or not?
> [Federation] Support
> refreshSuperUserGroupsConfiguration、refreshUserToGroupsMappings API's for
> Federation
> ---------------------------------------------------------------------------------------------------------
>
> Key: YARN-11374
> URL: https://issues.apache.org/jira/browse/YARN-11374
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation, router
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> In this jira, we will complete the refreshSuperUserGroupsConfiguration and
> refreshUserToGroupsMappings methods of FederationRMAdminInterceptor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
