[ https://issues.apache.org/jira/browse/YARN-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649900#comment-17649900 ]
ASF GitHub Bot commented on YARN-11388: --------------------------------------- cnauroth commented on PR #5187: URL: https://github.com/apache/hadoop/pull/5187#issuecomment-1359884012 > > @szilard-nemeth and @slfan1989 , I noticed you have been pretty active in the ResourceManager tests. Are you available to review this? Thank you. > > @cnauroth Thank you so much for inviting me to look at the code, I took a quick look, LGTM, I'll take a closer look at it again later. Thank you, @slfan1989 ! > Prevent resource leaks in TestClientRMService. > ---------------------------------------------- > > Key: YARN-11388 > URL: https://issues.apache.org/jira/browse/YARN-11388 > Project: Hadoop YARN > Issue Type: Test > Components: test > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Priority: Minor > Labels: pull-request-available > > While working on YARN-11360, I noticed a few problems in > {{TestClientRMService}} that made it difficult to work with. Tests do not > guarantee that servers they start up get shutdown. If an individual test > fails, then it can leave TCP sockets bound, causing subsequent tests in the > suite to fail on their socket bind attempts for the same port. There is also > a file generated by a test that is leaking outside of the build directory > into the source tree. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org