[ https://issues.apache.org/jira/browse/YARN-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651334#comment-17651334 ]
ASF GitHub Bot commented on YARN-6412: -------------------------------------- bteke commented on code in PR #5242: URL: https://github.com/apache/hadoop/pull/5242#discussion_r1055636201 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ########## @@ -2459,6 +2459,24 @@ <value>0</value> </property> + <property> + <description>Provide local directory which includes the related jar file as well as all the dependencies’ + jar file. We could specify the single jar file or use ${local_dir_to_jar}/* to load all + jars under the dep directory.</description> + <name>yarn.nodemanager.aux-services.%s.classpath</name> + <value>NONE</value> + </property> + + <property> + <description>Normally, we do not need to set this configuration. The class would be loaded from customized classpath + if it does not belongs to system-classes. For example, by default, the package org.apache.hadoop is in the Review Comment: Nit: typo, belongs -> belong. And following along the lines of the first comment: > For example, by default, the package org.apache.hadoop is in the system-classes, if your class CustomAuxService is in the package org.apache.hadoop, it would not be loaded from customized classpath. To solve this, either we could change the package for CustomAuxService, or configure our own system-classes which exclude org.apache.hadoop. could be: > By default, the package org.apache.hadoop is part of the system-classes. If for example the class CustomAuxService is in the package org.apache.hadoop, it will not be loaded from the customized classpath. To solve this, either the package of CustomAuxService could be changed, or a separate system-classes could be configured which excludes the package org.apache.hadoop. ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml: ########## @@ -2459,6 +2459,24 @@ <value>0</value> </property> + <property> + <description>Provide local directory which includes the related jar file as well as all the dependencies’ + jar file. We could specify the single jar file or use ${local_dir_to_jar}/* to load all + jars under the dep directory.</description> + <name>yarn.nodemanager.aux-services.%s.classpath</name> + <value>NONE</value> + </property> + + <property> + <description>Normally, we do not need to set this configuration. The class would be loaded from customized classpath Review Comment: Nit: I think saying something like: "Normally this configuration shouldn't be manually set." fit a bit more in the rest of the doc. > aux-services classpath not documented > ------------------------------------- > > Key: YARN-6412 > URL: https://issues.apache.org/jira/browse/YARN-6412 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Miklos Szegedi > Assignee: Riya Khandelwal > Priority: Minor > Labels: docuentation, newbie, pull-request-available > > YARN-4577 introduced two new configuration entries > yarn.nodemanager.aux-services.%s.classpath and > yarn.nodemanager.aux-services.%s.system-classes. These are not documented in > hadoop-yarn-common/.../yarn-default.xml -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org