[ https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847208#comment-13847208 ]
Zhijie Shen commented on YARN-1413: ----------------------------------- Some comments: 1. The wrong javadoc bellow: {code} + /* + * (non-Javadoc) + * + * @see + * org.apache.hadoop.mapreduce.v2.hs.webapp.AHSView#preHead(org.apache.hadoop + * .yarn.webapp.hamlet.Hamlet.HTML) + */ {code} {code} + /** + * The content of this page is the JobBlock + * + * @return HsJobBlock.class + */ {code} 2. I think the better way to construct the logURL in attempt/container blocks is to use ContainerReport.getLogURL directly (adding host:port prefix), instead of combining several attributes. The logURL should be set correctly in RMContainer final transition. > [YARN-321] AHS WebUI should server aggregated logs as well > ---------------------------------------------------------- > > Key: YARN-1413 > URL: https://issues.apache.org/jira/browse/YARN-1413 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Zhijie Shen > Assignee: Mayank Bansal > Attachments: YARN-1413-1.patch > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)