[
https://issues.apache.org/jira/browse/YARN-11326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705443#comment-17705443
]
ASF GitHub Bot commented on YARN-11326:
---------------------------------------
goiri commented on code in PR #4963:
URL: https://github.com/apache/hadoop/pull/4963#discussion_r1149505746
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -283,154 +290,229 @@ public void checkVersion() throws Exception {
@Override
public GetSubClusterPolicyConfigurationResponse getPolicyConfiguration(
GetSubClusterPolicyConfigurationRequest request) throws YarnException {
- return stateStoreClient.getPolicyConfiguration(request);
+ FederationClientMethod clientMethod = new FederationClientMethod(
Review Comment:
Or actually just specify it as an arg:
```
FederationClientMethod clientMethod = new FederationClientMethod(
"getPolicyConfiguration", GetSubClusterPolicyConfigurationRequest.class,
request,
GetSubClusterPolicyConfigurationResponse.class,
stateStoreClient, clock);
```
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/federation/FederationStateStoreService.java:
##########
@@ -283,154 +290,229 @@ public void checkVersion() throws Exception {
@Override
public GetSubClusterPolicyConfigurationResponse getPolicyConfiguration(
GetSubClusterPolicyConfigurationRequest request) throws YarnException {
- return stateStoreClient.getPolicyConfiguration(request);
+ FederationClientMethod clientMethod = new FederationClientMethod(
Review Comment:
Wouldn't it make more sense to make it:
```
FederationClientMethod<GetSubClusterPolicyConfigurationResponse>
```
?
> [Federation] Add RM FederationStateStoreService Metrics
> -------------------------------------------------------
>
> Key: YARN-11326
> URL: https://issues.apache.org/jira/browse/YARN-11326
> Project: Hadoop YARN
> Issue Type: Bug
> Components: federation, resourcemanager
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> RM FederationStateStoreService lacks Metric information, increase Metric
> information statistics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
