[
https://issues.apache.org/jira/browse/YARN-11000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717166#comment-17717166
]
ASF GitHub Bot commented on YARN-11000:
---------------------------------------
brumi1024 commented on code in PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#discussion_r1179074067
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java:
##########
@@ -1392,4 +1412,15 @@ public void
testContainerRejectionWhenAskBeyondDynamicMax()
rm1.close();
}
+
+ private CapacityScheduler getCapacityScheduler(MockRM rm1, int memoryGb) {
Review Comment:
The name getCapacityScheduler is misleading. A getter shouldn't set up
clusterResources or init the queue structure. I would prefer if there was a
separate getter and a mockCS "reinit" method, which sets up the resources and
queues.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestContainerAllocation.java:
##########
@@ -1392,4 +1412,15 @@ public void
testContainerRejectionWhenAskBeyondDynamicMax()
rm1.close();
}
+
+ private CapacityScheduler getCapacityScheduler(MockRM rm1, int memoryGb) {
Review Comment:
The name getCapacityScheduler is misleading. A getter shouldn't set up
clusterResources or init the queue structure. I would prefer if there was a
separate getter and a mockCS "reinit" method, which sets up the resources and
queues by calling the necessary methods.
> Replace queue resource calculation logic in updateClusterResource
> -----------------------------------------------------------------
>
> Key: YARN-11000
> URL: https://issues.apache.org/jira/browse/YARN-11000
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> YARN-10965 introduces a brand new queue calculation system. In order to
> simplify the review process, this issue replaces the current logic with the
> newly introduced one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
