[ https://issues.apache.org/jira/browse/YARN-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720781#comment-17720781 ]
ASF GitHub Bot commented on YARN-11479: --------------------------------------- slfan1989 commented on code in PR #5631: URL: https://github.com/apache/hadoop/pull/5631#discussion_r1188134599 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/ZookeeperFederationStateStore.java: ########## @@ -325,47 +328,53 @@ public AddApplicationHomeSubClusterResponse addApplicationHomeSubCluster( FederationApplicationHomeSubClusterStoreInputValidator.validate(request); ApplicationHomeSubCluster app = request.getApplicationHomeSubCluster(); ApplicationId appId = app.getApplicationId(); + ApplicationSubmissionContext appSubmissionContext = app.getApplicationSubmissionContext(); + + LOG.info("appId = {}, homeSubClusterId = {}, appSubmissionContext = {}.", appId, app, + appSubmissionContext); // Try to write the subcluster SubClusterId homeSubCluster = app.getHomeSubCluster(); try { - putApp(appId, homeSubCluster, false); + putApp(appId, app, false); } catch (Exception e) { String errMsg = "Cannot add application home subcluster for " + appId; FederationStateStoreUtils.logAndThrowStoreException(LOG, errMsg); } // Check for the actual subcluster try { - homeSubCluster = getApp(appId); + ApplicationHomeSubCluster appHomeSubCluster = getApp(appId); Review Comment: I will refactor this part of the code for better code readability. 1. The `added` or `updated` method name is `storeOrUpdateApplicationHomeSubCluster`. 2. The `get` method is `getApplicationHomeSubCluster`. > [Federation] ZookeeperFederationStateStore Support Store ApplicationSubmitData > ------------------------------------------------------------------------------ > > Key: YARN-11479 > URL: https://issues.apache.org/jira/browse/YARN-11479 > Project: Hadoop YARN > Issue Type: Improvement > Components: federation > Affects Versions: 3.4.0 > Reporter: Shilun Fan > Assignee: Shilun Fan > Priority: Major > Labels: pull-request-available > > Before completing YARN-8898, we need to store ApplicationSubmitData in > FederationStateStore first, this jira will store ApplicationSubmitData in > ZookeeperFederationStateStore. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org