[
https://issues.apache.org/jira/browse/YARN-11000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729086#comment-17729086
]
ASF GitHub Bot commented on YARN-11000:
---------------------------------------
9uapaw commented on code in PR #3618:
URL: https://github.com/apache/hadoop/pull/3618#discussion_r1216949143
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestApplicationLimits.java:
##########
@@ -194,6 +207,8 @@ public void testAMResourceLimit() throws Exception {
Resource clusterResource = Resource.newInstance(80 * GB, 40);
root.updateClusterResource(clusterResource, new ResourceLimits(
clusterResource));
+ LeafQueue queue = (LeafQueue) root.getChildQueues().stream().filter(
+ child ->
child.getQueueName().equals(A)).findFirst().orElseThrow(NoSuchElementException::new);
Review Comment:
Its been a while since I made these changes, but as I remember this
phenomenon was repeated multiple times in several tests and caused a lot of
headaches. Essentially, the original LeafQueue which was spied upon is not part
of the queue hierarchy, but instantiated separately in this test file only,
therefore it will not be a part of the calculation steps either. IMO we should
never initialize queues like this.
> Replace queue resource calculation logic in updateClusterResource
> -----------------------------------------------------------------
>
> Key: YARN-11000
> URL: https://issues.apache.org/jira/browse/YARN-11000
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacity scheduler
> Reporter: Andras Gyori
> Assignee: Andras Gyori
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> YARN-10965 introduces a brand new queue calculation system. In order to
> simplify the review process, this issue replaces the current logic with the
> newly introduced one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
