[
https://issues.apache.org/jira/browse/YARN-11504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730394#comment-17730394
]
ASF GitHub Bot commented on YARN-11504:
---------------------------------------
slfan1989 commented on code in PR #5722:
URL: https://github.com/apache/hadoop/pull/5722#discussion_r1222483790
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/RMProxy.java:
##########
@@ -116,6 +116,28 @@ protected static <T> T createRMProxy(final Configuration
configuration,
return newProxyInstance(conf, protocol, instance, retryPolicy);
}
+ /**
+ * Currently, used by NodeManagers only.
+ *
+ * @param configuration configuration.
+ * @param protocol protocol.
+ * @param instance RMProxy instance.
+ * @return RMProxy.
+ * @param <T> Generic T.
+ * @throws IOException io error occur.
+ */
+ protected static <T> T createRMProxyFederation(final Configuration
configuration,
+ final Class<T> protocol, RMProxy<T> instance) throws IOException {
+ YarnConfiguration yarnConf =
+ (configuration instanceof YarnConfiguration) ? (YarnConfiguration)
configuration :
+ new YarnConfiguration(configuration);
+ if(isFederationNonHAEnabled(yarnConf)){
Review Comment:
Thank you very much for your help to review the code! I will modify the code.
> [Federation] YARN Federation Supports Non-HA mode.
> --------------------------------------------------
>
> Key: YARN-11504
> URL: https://issues.apache.org/jira/browse/YARN-11504
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: federation, nodemanager
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
> I am testing the functionality of YARN Federation and have set up the
> simplest test environment for this purpose. I found that if I set up a non-HA
> mode test environment, MR/Spark jobs cannot run normally. This JIRA will fix
> this issue.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
