[ https://issues.apache.org/jira/browse/YARN-11509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736398#comment-17736398 ]
ASF GitHub Bot commented on YARN-11509: --------------------------------------- slfan1989 commented on code in PR #5727: URL: https://github.com/apache/hadoop/pull/5727#discussion_r1239513085 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java: ########## @@ -29,12 +29,7 @@ import java.util.Map; import java.util.Map.Entry; import java.util.Set; -import java.util.concurrent.Callable; -import java.util.concurrent.ConcurrentHashMap; -import java.util.concurrent.ExecutorCompletionService; -import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; -import java.util.concurrent.Future; +import java.util.concurrent.*; Review Comment: Thanks for helping to review the code, I will fix it. > The FederationInterceptor#launchUAM Added retry logic. > ------------------------------------------------------ > > Key: YARN-11509 > URL: https://issues.apache.org/jira/browse/YARN-11509 > Project: Hadoop YARN > Issue Type: Improvement > Components: amrmproxy > Affects Versions: 3.4.0 > Reporter: Shilun Fan > Assignee: Shilun Fan > Priority: Minor > Labels: pull-request-available > > There is a "todo" in the > FederationInterceptor#registerAndAllocateWithNewSubClusters method. According > to the "todo" description, the request needs to be retried to other > subclusters, but changing the parameter requests in > registerAndAllocateWithNewSubClusters is not a good operation. It is better > to add retry logic here. > We don't need to worry about losing requests because when the request cannot > be satisfied, the AM of the task will continue to apply, and these requests > will be properly transferred to other clusters for execution. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org