[ 
https://issues.apache.org/jira/browse/YARN-11000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740051#comment-17740051
 ] 

ASF GitHub Bot commented on YARN-11000:
---------------------------------------

tomicooler commented on code in PR #5783:
URL: https://github.com/apache/hadoop/pull/5783#discussion_r1252663785


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java:
##########
@@ -384,6 +388,38 @@ protected void setupQueueConfigs(Resource clusterResource) 
throws
           .parseConfiguredMaximumCapacityVector(queuePath.getFullPath(),
               this.queueNodeLabelsSettings.getConfiguredNodeLabels(),
               QueueCapacityVector.newInstance());
+
+      // Preserving the capacities set by Entitlements
+      if (this instanceof ReservationQueue ||
+          this instanceof PlanQueue) {
+        for (final String label : 
queueNodeLabelsSettings.getConfiguredNodeLabels()) {
+          setConfiguredMinCapacityVector(label,
+              QueueCapacityVector.of(queueCapacities.getCapacity(label) * 100,
+                  QueueCapacityVector.ResourceUnitCapacityType.PERCENTAGE));
+          setConfiguredMaxCapacityVector(label,
+              QueueCapacityVector.of(queueCapacities.getMaximumCapacity(label) 
* 100,
+                  QueueCapacityVector.ResourceUnitCapacityType.PERCENTAGE));
+        }
+      }
+
+      // Re-adjust weight when mixed capacity type is used. 5w == [memory=5w, 
vcores=5w]

Review Comment:
   Yes, e.g.: `testSchedulerAbsoluteAndWeightUsingCapacityVector`





> Replace queue resource calculation logic in updateClusterResource
> -----------------------------------------------------------------
>
>                 Key: YARN-11000
>                 URL: https://issues.apache.org/jira/browse/YARN-11000
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacity scheduler
>            Reporter: Andras Gyori
>            Assignee: Andras Gyori
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> YARN-10965 introduces a brand new queue calculation system. In order to 
> simplify the review process, this issue replaces the current logic with the 
> newly introduced one.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to