[ https://issues.apache.org/jira/browse/YARN-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850174#comment-13850174 ]
Jian He commented on YARN-1121: ------------------------------- bq. I also think the sync should be outside the while loop to protect drained variable? Disregard this comment, given drained is a volatile, I think it's fine to put sync inside the while loop. > RMStateStore should flush all pending store events before closing > ----------------------------------------------------------------- > > Key: YARN-1121 > URL: https://issues.apache.org/jira/browse/YARN-1121 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.1.0-beta > Reporter: Bikas Saha > Assignee: Jian He > Fix For: 2.4.0 > > Attachments: YARN-1121.1.patch, YARN-1121.2.patch, YARN-1121.2.patch, > YARN-1121.3.patch, YARN-1121.4.patch, YARN-1121.5.patch, YARN-1121.6.patch, > YARN-1121.6.patch, YARN-1121.7.patch, YARN-1121.8.patch > > > on serviceStop it should wait for all internal pending events to drain before > stopping. -- This message was sent by Atlassian JIRA (v6.1.4#6159)