[
https://issues.apache.org/jira/browse/YARN-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746848#comment-17746848
]
ASF GitHub Bot commented on YARN-11520:
---------------------------------------
brumi1024 commented on code in PR #5871:
URL: https://github.com/apache/hadoop/pull/5871#discussion_r1273195384
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java:
##########
@@ -463,12 +463,14 @@ protected void setDynamicQueueProperties() {
queueContext.getQueueManager().getConfiguredNodeLabelsForAllQueues()
.setLabelsByQueue(getQueuePath(), new
HashSet<>(parentNodeLabels));
}
+ Map<String, QueueCapacityVector> templateConfiguredResourceVector =
queueContext.getConfiguration()
+ .parseConfiguredResourceVector(queuePath.getFullPath(),
parentNodeLabels);
+
Review Comment:
This is just for validating if the template contained resource vectors,
because we need to set weight to 1 if not. The issue here was that we already
parsed the capacity vectors we just simply overrode them with
"queueContext.getConfiguration().setLabeledQueueWeight(queuePath.getFullPath(),
label, 1);"
But I've refactored this, as we don't need to iterate through the node
labels this many times.
> Support capacity vector for AQCv2 dynamic templates
> ---------------------------------------------------
>
> Key: YARN-11520
> URL: https://issues.apache.org/jira/browse/YARN-11520
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: capacityscheduler
> Affects Versions: 3.4.0
> Reporter: Tamas Domok
> Assignee: Benjamin Teke
> Priority: Major
> Labels: pull-request-available
>
> AQCv2 dynamic queue templates should support the new capacity modes.
> e.g.:
> {code}
> auto-queue-creation-v2.parent-template.capacity = [memory=12288, vcores=86%]
> auto-queue-creation-v2.leaf-template.capacity = [memory=1w, vcores=1]
> auto-queue-creation-v2.template.capacity = [memory=20%, vcores=50%]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
