[ 
https://issues.apache.org/jira/browse/YARN-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17751030#comment-17751030
 ] 

ASF GitHub Bot commented on YARN-11416:
---------------------------------------

brumi1024 merged PR #5320:
URL: https://github.com/apache/hadoop/pull/5320




> FS2CS should use CapacitySchedulerConfiguration in FSQueueConverterBuilder 
> ---------------------------------------------------------------------------
>
>                 Key: YARN-11416
>                 URL: https://issues.apache.org/jira/browse/YARN-11416
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Benjamin Teke
>            Assignee: Susheel Gupta
>            Priority: Major
>              Labels: pull-request-available
>
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.converter.FSQueueConverter
>  and its builder stores the variable capacitySchedulerConfig as a simple 
> Configuration object instead of CapacitySchedulerConfiguration. This is 
> misleading, as capacitySchedulerConfig suggests that it is indeed a 
> CapacitySchedulerConfiguration and it loses access to the convenience methods 
> to check for various properties. Because of this every time a property getter 
> is changed FS2CS should be checked if it reimplemented the same, otherwise 
> there might be behaviour differences or even bugs.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to