[ https://issues.apache.org/jira/browse/YARN-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850955#comment-13850955 ]
Sandy Ryza commented on YARN-1414: ---------------------------------- Thanks for finding this Siqi. This will fix the issue for the root queue, but, if I understand correctly the accounting will still be incorrect for child queues. Also, a couple stylistic comments. {code} + public void testSchedulerRootQueueMetricsWhenKillWaitingJobs() throws InterruptedException { {code} Goes significantly over 80 characters {code} + getRootQueueMetrics().unreserveResource( + application.getUser(), rmContainer.getContainer().getResource()); {code} Second line should be indented 4 spaces past first one Lastly, because of recent changes, scheduler.reinitialize(conf, resourceManager.getRMContext()) will need to be added to the beginning of the test. > with Fair Scheduler reserved MB in WebUI is leaking when killing waiting jobs > ----------------------------------------------------------------------------- > > Key: YARN-1414 > URL: https://issues.apache.org/jira/browse/YARN-1414 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager, scheduler > Affects Versions: 2.0.5-alpha > Reporter: Siqi Li > Assignee: Siqi Li > Fix For: 2.2.0 > > Attachments: YARN-1221-subtask.v1.patch.txt > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)