[ 
https://issues.apache.org/jira/browse/YARN-11592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776967#comment-17776967
 ] 

ASF GitHub Bot commented on YARN-11592:
---------------------------------------

slfan1989 commented on code in PR #6189:
URL: https://github.com/apache/hadoop/pull/6189#discussion_r1364784715


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-globalpolicygenerator/src/main/java/org/apache/hadoop/yarn/server/globalpolicygenerator/GPGUtils.java:
##########
@@ -128,4 +130,16 @@ public static Map<SubClusterIdInfo, Float> 
createUniformWeights(
     }
     return weights;
   }
+
+  @VisibleForTesting

Review Comment:
   Thanks for your suggestion! I will fix this issue.





> Add timeout to GPGUtils#invokeRMWebService.
> -------------------------------------------
>
>                 Key: YARN-11592
>                 URL: https://issues.apache.org/jira/browse/YARN-11592
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: federation
>    Affects Versions: 3.4.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Major
>              Labels: pull-request-available
>
> GPGUtils#invokeRMWebService utilizes a Client, and we should set a timeout 
> for the Client.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to