[ https://issues.apache.org/jira/browse/YARN-11614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786787#comment-17786787 ]
ASF GitHub Bot commented on YARN-11614: --------------------------------------- slfan1989 commented on code in PR #6271: URL: https://github.com/apache/hadoop/pull/6271#discussion_r1395856958 ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/FederationQueueWeight.java: ########## @@ -170,6 +170,26 @@ public static void checkHeadRoomAlphaValid(String headRoomAlpha) throws YarnExce } } + public static void checkPolicyManagerValid(String policyManager) throws YarnException { + switch (policyManager) { + case "org.apache.hadoop.yarn.server.federation.policies.manager.HashBroadcastPolicyManager": + throw new YarnException("HashBroadcastPolicyManager does not support the use of queue weights."); + case "org.apache.hadoop.yarn.server.federation.policies.manager.HomePolicyManager": + throw new YarnException("HomePolicyManager does not support the use of queue weights."); Review Comment: I will improve this part of the code. > [Federation] Add Federation PolicyManager Validation Rules > ---------------------------------------------------------- > > Key: YARN-11614 > URL: https://issues.apache.org/jira/browse/YARN-11614 > Project: Hadoop YARN > Issue Type: Sub-task > Components: federation > Affects Versions: 3.4.0 > Reporter: Shilun Fan > Assignee: Shilun Fan > Priority: Major > Labels: pull-request-available > > When entering queue weights in Federation, it is essential to enhance the > validation rules. If a policy manager does not support weights, a prompt > should be provided to the user. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org