[
https://issues.apache.org/jira/browse/YARN-11634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798658#comment-17798658
]
ASF GitHub Bot commented on YARN-11634:
---------------------------------------
K0K0V0K commented on code in PR #6371:
URL: https://github.com/apache/hadoop/pull/6371#discussion_r1431687597
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java:
##########
@@ -78,6 +78,7 @@ public void setup() {
conf.setBoolean(YarnConfiguration.TIMELINE_SERVICE_ENABLED, true);
conf.setFloat(YarnConfiguration.TIMELINE_SERVICE_VERSION, 1.0f);
client = createTimelineClient(conf);
+ TimelineConnector.DEFAULT_SOCKET_TIMEOUT = 10;
Review Comment:
well... it is a good question that made me wonder in case of a successful
connection how long the KerberosAuthenticator#190 connect is running, and the
plot-twist i just realized all of the tests expect timeout here 😅
If you add a some debug point before and after this line we can observe the
debug point after the connect will never be triggered, so technically we can
also write 1ms here, the tests can not be broken
> Speed-up TestTimelineClient
> ---------------------------
>
> Key: YARN-11634
> URL: https://issues.apache.org/jira/browse/YARN-11634
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: yarn
> Reporter: Bence Kosztolnik
> Assignee: Bence Kosztolnik
> Priority: Minor
> Labels: pull-request-available
>
> The TimelineConnector.class has a hardcoded 1-minute connection time out,
> which makes the TestTimelineClient a long-running test (~15:30 min).
> Decreasing the timeout to 10ms will speed up the test run (~56 sec).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
