[ 
https://issues.apache.org/jira/browse/YARN-11634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805337#comment-17805337
 ] 

ASF GitHub Bot commented on YARN-11634:
---------------------------------------

slfan1989 commented on code in PR #6419:
URL: https://github.com/apache/hadoop/pull/6419#discussion_r1448159809


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestTimelineClient.java:
##########
@@ -89,7 +89,7 @@ public void tearDown() throws Exception {
     if (isSSLConfigured()) {
       KeyStoreTestUtil.cleanupSSLConfig(keystoresDir, sslConfDir);
     }
-    TimelineConnector.DEFAULT_SOCKET_TIMEOUT = 60_000;
+    client.getConnector().setSocketTimeOut(60_1000);

Review Comment:
   @K0K0V0K Thanks for the review! I will improve it.





> Speed-up TestTimelineClient
> ---------------------------
>
>                 Key: YARN-11634
>                 URL: https://issues.apache.org/jira/browse/YARN-11634
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: yarn
>            Reporter: Bence Kosztolnik
>            Assignee: Bence Kosztolnik
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.4.0
>
>
> The TimelineConnector.class has a hardcoded 1-minute connection time out, 
> which makes the TestTimelineClient a long-running test (~15:30 min).
> Decreasing the timeout to 10ms will speed up the test run (~56 sec).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to