[
https://issues.apache.org/jira/browse/YARN-11137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shilun Fan updated YARN-11137:
------------------------------
Target Version/s: 3.4.0
> Improve log message in FederationClientInterceptor
> --------------------------------------------------
>
> Key: YARN-11137
> URL: https://issues.apache.org/jira/browse/YARN-11137
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: federation
> Affects Versions: 3.4.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: YARN-11137.01.patch, YARN-11137.02.patch
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> While reading the relevant yarn-federation-router's code, I found the
> following issues with log method in FederationClientInterceptor:
> The log methods are inconsistent, some use the splicing method, and some use
> the placeholder method，as follows:
> org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#getNewApplication
> {code:java}
> for (int i = 0; i < numSubmitRetries; ++i) {
> SubClusterId subClusterId =
> getRandomActiveSubCluster(subClustersActive);
> LOG.debug(
> "getNewApplication try #{} on SubCluster {}", i, subClusterId);
> ApplicationClientProtocol clientRMProxy =
> getClientRMProxyForSubCluster(subClusterId);
> ...
> }{code}
> org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#submitApplication
> {code:java}
> for (int i = 0; i < numSubmitRetries; ++i) {
> SubClusterId subClusterId = policyFacade.getHomeSubcluster(
> request.getApplicationSubmissionContext(), blacklist);
> LOG.info("submitApplication appId" + applicationId + " try #" + i
> + " on SubCluster " + subClusterId);
> ...
> } {code}
> I think the first way is better.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
